Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging so global voc resources don't appear as errors in the log #126

Merged
merged 1 commit into from Jun 1, 2022

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jun 1, 2022

Calls to self.ask_yesno and other MycroftSkill methods would log a warning that a resource wasn't found (yes.voc, no.voc, cancel.voc, etc) but those appear to be resolved after the logged warning. This PR slightly changes wording and reduces logs to INFO as well as logs when the resource is resolved from globals

@NeonDaniel NeonDaniel requested a review from JarbasAl June 1, 2022 20:47
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #126 (a9ee4fc) into dev (6ceb058) will increase coverage by 2.96%.
The diff coverage is 34.98%.

@@            Coverage Diff             @@
##              dev     #126      +/-   ##
==========================================
+ Coverage   50.35%   53.31%   +2.96%     
==========================================
  Files         119      149      +30     
  Lines       10077     9076    -1001     
==========================================
- Hits         5074     4839     -235     
+ Misses       5003     4237     -766     
Impacted Files Coverage Δ
mycroft/api/__init__.py 30.24% <0.00%> (-47.99%) ⬇️
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b174686...a9ee4fc. Read the comment docs.

@JarbasAl JarbasAl merged commit 8ce785e into dev Jun 1, 2022
@JarbasAl JarbasAl deleted the LOG_UpdateResourceResolutionLogging branch June 1, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants