port of the resource file handling refactor from mk2 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
refactor
JarbasAl
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #130 +/- ##
==========================================
+ Coverage 50.35% 52.88% +2.53%
==========================================
Files 119 150 +31
Lines 10077 9566 -511
==========================================
- Hits 5074 5059 -15
+ Misses 5003 4507 -496
Continue to review full report at Codecov.
|
NeonJarbas
force-pushed
the
port/mk2_resource_handling
branch
2 times, most recently
from
a48d0e0
to
62666ac
Compare
cherry-picked commits: - add the logic for "template" resource files back in. - add the logic for "template" resource files back in. - add regex file loading for skill into resources code - added support for .word files and fixed a regex bug - fixes a bug where the dialog data is not passed to the renderer - removed spurious print statements - another iteration of improving the resource file handling - update dialog renderer in the translator after all dialogs are loaded - Move resource file location and translation logic into skill_data.py
NeonJarbas
force-pushed
the
port/mk2_resource_handling
branch
from
62666ac
to
7e40ee1
Compare
increases compatibility with mark2 while remaining fully backwards compatible. More mark2 exclusive skills will be able to run squashed commits: - add CoreResources helper class - move find_resource logic to skill_data.py - cache resources per lang to avoid excessive file reads - adapt compat - move dialog_renderer to SkillResources - add back multi lang support - restore old methods for backwards compat
NeonJarbas
force-pushed
the
port/mk2_resource_handling
branch
from
353f775
to
876f0c1
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
port of the resource file handling refactor https://github.com/MycroftAI/mycroft-core/blob/mark-ii/qa/mycroft/skills/skill_data.py
this PR increases compatibility with mark2 while remaining fully backwards compatible.
More mark2 exclusive skills will be able to run in ovos-core once this is merged
cherry picked commits from mark2:
credits of the original refactor go to @chrisveilleux
ovos improvements:
dialog_rendererto live in the newSkillResourcesclassself.find_resourceand move it to skill_data.py