Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/user resources #131

Merged
merged 1 commit into from Jun 4, 2022
Merged

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Jun 4, 2022

sometimes users want to add or override the resource files included by skills

this commit adds support for user defined resource files at {$XDG_DATA_HOME}/mycroft/resources/{skill_id}

files in that directory will be given preference over files shipped by the skill, this allows personalizing your assistant dialogs and helps development as well as language support

related issue MycroftAI#2509 and chat discussion https://chat.mycroft.ai/community/pl/a5m96ba5hbyrtq6hdukcyd6dmo

this builds on #130

sometimes users want to add or override the resource files included by skills

this commit adds support for user defined resource files at {XDG_DATA_HOME}/mycroft/resources/{skill_id}

files in that directory will be given preference over files shipped by the skill, this allows personalizing your assistant dialogs and helps development as well as language support
@JarbasAl JarbasAl added the enhancement New feature or request label Jun 4, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel June 4, 2022 16:50
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #131 (08ff363) into dev (6ceb058) will increase coverage by 2.54%.
The diff coverage is 41.58%.

@@            Coverage Diff             @@
##              dev     #131      +/-   ##
==========================================
+ Coverage   50.35%   52.90%   +2.54%     
==========================================
  Files         119      150      +31     
  Lines       10077     9586     -491     
==========================================
- Hits         5074     5071       -3     
+ Misses       5003     4515     -488     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f81a6f...08ff363. Read the comment docs.

@JarbasAl JarbasAl merged commit 00a9fb8 into OpenVoiceOS:dev Jun 4, 2022
4 of 5 checks passed
@NeonJarbas NeonJarbas deleted the feat/user_resources branch June 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants