Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/setup_events #136

Merged
merged 2 commits into from Jun 5, 2022
Merged

feat/setup_events #136

merged 2 commits into from Jun 5, 2022

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Jun 5, 2022

refactor readiness check to handle generic setup skills and not depend specifically on pairing

this makes things event based and allows setup flows that do not require pairing

this requires latest ovos-setup skill, to test enable pairing requirement in mycroft.conf

https://github.com/OpenVoiceOS/skill-ovos-setup

refactor readiness check to handle generic setup skills and not depend specifically on pairing

this makes things event based and allows setup flows that do not require pairing
@JarbasAl JarbasAl added the enhancement New feature or request label Jun 5, 2022
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #136 (90d668c) into dev (6ceb058) will increase coverage by 2.46%.
The diff coverage is 41.59%.

@@            Coverage Diff             @@
##              dev     #136      +/-   ##
==========================================
+ Coverage   50.35%   52.81%   +2.46%     
==========================================
  Files         119      150      +31     
  Lines       10077     9603     -474     
==========================================
- Hits         5074     5072       -2     
+ Misses       5003     4531     -472     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf8d16...90d668c. Read the comment docs.

@JarbasAl JarbasAl merged commit 33dba93 into OpenVoiceOS:dev Jun 5, 2022
@NeonJarbas NeonJarbas deleted the feat/setup_events branch June 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants