fix/filesystem_path_collision #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self.file_system was using the XDG skills path, causing a reload of skill everytime it was used. this commit moves it to a subfolder to avoid this collision this is an instance of 2 bugs cancelling each other out, since filesystem was wrongly using XDG_CONFIG this bug was hidden during the migration of skills to the xdg spec and only surfaced after that being fixed
JarbasAl
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #138 +/- ##
==========================================
+ Coverage 50.35% 52.81% +2.46%
==========================================
Files 119 150 +31
Lines 10077 9603 -474
==========================================
- Hits 5074 5072 -2
+ Misses 5003 4531 -472
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
self.file_system was using the XDG skills path, causing a reload of skill everytime it was used.
this commit moves it to a subfolder to avoid this collision
this is an instance of 2 bugs cancelling each other out, since filesystem was wrongly using XDG_CONFIG this bug was hidden during the migration of skills to the xdg spec and only surfaced after #133