Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/skill_settings_filewatch #139

Merged
merged 4 commits into from Jun 6, 2022

Conversation

NeonJarbas
Copy link

builds up on the FileWatcher class introduced in #105 and cleans up a couple things from that PR

  • makes skill settings react to file system changes
  • moves the config deprecation logs so they are only printed once
  • removes a unused (and buggy) patch message emit

- makes skill settings react to file system changes
- moves the config deprecation logs so they are only printed once
- removes a unused (and buggy) patch message emit
@JarbasAl JarbasAl added bug Something isn't working enhancement New feature or request labels Jun 6, 2022
@JarbasAl JarbasAl requested review from NeonDaniel and AIIX June 6, 2022 13:34
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #139 (dac7f48) into dev (6ceb058) will increase coverage by 2.47%.
The diff coverage is 41.92%.

❗ Current head dac7f48 differs from pull request most recent head ee63987. Consider uploading reports for the commit ee63987 to get more accurate results

@@            Coverage Diff             @@
##              dev     #139      +/-   ##
==========================================
+ Coverage   50.35%   52.82%   +2.47%     
==========================================
  Files         119      150      +31     
  Lines       10077     9670     -407     
==========================================
+ Hits         5074     5108      +34     
+ Misses       5003     4562     -441     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74eb566...ee63987. Read the comment docs.

@JarbasAl JarbasAl merged commit 6d3ba32 into OpenVoiceOS:dev Jun 6, 2022
@NeonJarbas NeonJarbas deleted the fix/skillsetings_filewatch branch June 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants