Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/feat/improve_cq_matching #141

Merged
merged 1 commit into from Jun 8, 2022

Conversation

NeonJarbas
Copy link

improves common query by not wasting time with utterances that are not questions

initial implementation is very simple:

  • filter utterances with less than 3 words (stop/yes/no/continue/resume ....)
  • filter utterances containing common play keywords

improves common query by not wasting time with utterances that are not questions

initial implementation is very simple:
- filter utterances with less than 3 words (stop/yes/no/continue/resume ....)
- filter utterances containing common play keywords
@JarbasAl JarbasAl added the enhancement New feature or request label Jun 8, 2022
@JarbasAl JarbasAl requested review from j1nx and NeonDaniel June 8, 2022 18:39
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #141 (f487362) into dev (6ceb058) will increase coverage by 2.40%.
The diff coverage is 41.82%.

@@            Coverage Diff             @@
##              dev     #141      +/-   ##
==========================================
+ Coverage   50.35%   52.75%   +2.40%     
==========================================
  Files         119      150      +31     
  Lines       10077     9697     -380     
==========================================
+ Hits         5074     5116      +42     
+ Misses       5003     4581     -422     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab20a5...f487362. Read the comment docs.

@JarbasAl JarbasAl merged commit 1165585 into OpenVoiceOS:dev Jun 8, 2022
@NeonJarbas NeonJarbas deleted the feat/improve_cq_matching branch January 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants