fix/config_hotreload #142
Merged
fix/config_hotreload #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes config would reload before the write finished, this commits makes it retry and if it fails gives a more useful error log about invalid syntax
Codecov Report
@@ Coverage Diff @@
## dev #142 +/- ##
==========================================
+ Coverage 50.35% 52.74% +2.39%
==========================================
Files 119 150 +31
Lines 10077 9688 -389
==========================================
+ Hits 5074 5110 +36
+ Misses 5003 4578 -425
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes config would reload before the write finished, this commits makes it retry and if it fails gives a more useful error log about invalid syntax