refactor/skill_reload #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor skill reloading to use the new FileWatcher class, this is now event based and should improve performance
NeonJarbas
force-pushed
the
refactor/skill_reload
branch
from
bc88972
to
0d87fe3
Compare
Codecov Report
@@ Coverage Diff @@
## dev #143 +/- ##
==========================================
+ Coverage 50.35% 52.73% +2.38%
==========================================
Files 119 150 +31
Lines 10077 9720 -357
==========================================
+ Hits 5074 5126 +52
+ Misses 5003 4594 -409
Continue to review full report at Codecov.
|
NeonDaniel
requested changes
Jun 8, 2022
NeonDaniel
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
refactor skill reloading to use the new FileWatcher class, this is now event based and should improve performance