Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/core_resources #145

Merged
merged 1 commit into from Jun 8, 2022
Merged

Conversation

NeonJarbas
Copy link

when using CoreResources skill_id is not set and an exception was thrown when scanning the user resources override path

a check is now added for skill_id

when using CoreResources skill_id is not set and an exception was thrown when scanning the user resources override path

a check is now added for skill_id
@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Jun 8, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel June 8, 2022 21:49
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #145 (10abbd3) into dev (6ceb058) will increase coverage by 2.32%.
The diff coverage is 41.64%.

@@            Coverage Diff             @@
##              dev     #145      +/-   ##
==========================================
+ Coverage   50.35%   52.68%   +2.32%     
==========================================
  Files         119      150      +31     
  Lines       10077     9713     -364     
==========================================
+ Hits         5074     5117      +43     
+ Misses       5003     4596     -407     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc990c6...10abbd3. Read the comment docs.

@JarbasAl JarbasAl merged commit 707d292 into OpenVoiceOS:dev Jun 8, 2022
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants