Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor audio module into service #146

Merged
merged 4 commits into from Jun 8, 2022
Merged

Refactor audio module into service #146

merged 4 commits into from Jun 8, 2022

Conversation

NeonDaniel
Copy link
Member

No description provided.

@NeonDaniel NeonDaniel requested a review from JarbasAl June 8, 2022 22:33
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #146 (1b873a7) into dev (6ceb058) will increase coverage by 2.70%.
The diff coverage is 42.47%.

@@            Coverage Diff             @@
##              dev     #146      +/-   ##
==========================================
+ Coverage   50.35%   53.05%   +2.70%     
==========================================
  Files         119      152      +33     
  Lines       10077     9769     -308     
==========================================
+ Hits         5074     5183     +109     
+ Misses       5003     4586     -417     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707d292...1b873a7. Read the comment docs.

mycroft/audio/service.py Outdated Show resolved Hide resolved
mycroft/audio/service.py Outdated Show resolved Hide resolved
mycroft/audio/service.py Outdated Show resolved Hide resolved
mycroft/audio/service.py Outdated Show resolved Hide resolved
@NeonDaniel NeonDaniel marked this pull request as ready for review June 8, 2022 23:35
@JarbasAl JarbasAl added the refactor code refactor without functional changes label Jun 8, 2022
@JarbasAl JarbasAl merged commit a92d035 into dev Jun 8, 2022
@JarbasAl JarbasAl deleted the FEAT_AudioServiceThread branch June 8, 2022 23:40
@JarbasAl JarbasAl added the breaking breaks backwards compatibility (kinda) label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaks backwards compatibility (kinda) refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants