hotfix/deprecated_method #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would potentially cause a infinite loop, simply log an error
Codecov Report
@@ Coverage Diff @@
## dev #147 +/- ##
==========================================
+ Coverage 50.35% 53.05% +2.70%
==========================================
Files 119 152 +33
Lines 10077 9769 -308
==========================================
+ Hits 5074 5183 +109
+ Misses 5003 4586 -417
Continue to review full report at Codecov.
|
NeonDaniel
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the event emiting itself would potentially cause a infinite loop if this is a bus handler (and it usually is)
simply log an error instead