refactor/rename_audiospeech_services #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename SpeechService to PlaybackService, this removes confusion with STT - rename SpeechClient to SpeechService, this was an oversight this is a breaking change, but it's ok because None of these exist in mycroft-core and version will be bumped
JarbasAl
added
refactor
Codecov Report
@@ Coverage Diff @@
## dev #151 +/- ##
==========================================
+ Coverage 50.35% 53.05% +2.70%
==========================================
Files 119 152 +33
Lines 10077 9779 -298
==========================================
+ Hits 5074 5188 +114
+ Misses 5003 4591 -412
Continue to review full report at Codecov.
|
NeonDaniel
requested changes
Jun 9, 2022
NeonDaniel
approved these changes
Jun 22, 2022
j1nx
reviewed
Jun 22, 2022
|
|
||
| class SpeechClient(SpeechService): | ||
| def __init__(self, *args, **kwargs): | ||
| LOG.warning("SpeechClient has been renamed to SpeechService, it will be removed in 0.1.0) |
There was a problem hiding this comment.
SyntaxError: unterminated string literal (detected at line 237)
There was a problem hiding this comment.
Not sure how I missed that in testing.. PR'd a fix #165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
this is a breaking change, but it's ok because None of these exist in mycroft-core and version will be bumped