feat/speak_error_flag #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a skill registered an event via self.add_event (recommend) it always speaks an error message when there is an exception, most of the time this is unwanted outside intents this commit puts this behind a flag but keeps default behavior (speak errors by default) to test use some failing common_query or common_play skill and verify that no error is spoken, this would be previously be spoken during the search phase even if skill was not selected
NeonDaniel
reviewed
Jun 9, 2022
NeonJarbas
commented
Jun 9, 2022
j1nx
approved these changes
Jun 10, 2022
NeonDaniel
requested changes
Jun 15, 2022
Codecov Report
@@ Coverage Diff @@
## dev #152 +/- ##
==========================================
+ Coverage 50.35% 53.05% +2.70%
==========================================
Files 119 152 +33
Lines 10077 9803 -274
==========================================
+ Hits 5074 5201 +127
+ Misses 5003 4602 -401
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
when a skill registered an event via self.add_event (recommend) it always speaks an error message when there is an exception, most of the time this is unwanted outside intents
this commit puts this behind a flag but keeps default behavior (speak errors by default)
to test use some failing common_query or common_play skill and verify that no error is spoken, this would be previously be spoken during the search phase even if skill was not selected