Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/native_ocp #154

Merged
merged 1 commit into from Jun 9, 2022
Merged

Conversation

NeonJarbas
Copy link

always use OCP as default audio backend unless it is not installed

always use OCP as default audio backend unless it is not installed
@JarbasAl JarbasAl added the refactor code refactor without functional changes label Jun 9, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel June 9, 2022 23:26
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #154 (a285819) into dev (6ceb058) will increase coverage by 2.69%.
The diff coverage is 42.61%.

@@            Coverage Diff             @@
##              dev     #154      +/-   ##
==========================================
+ Coverage   50.35%   53.04%   +2.69%     
==========================================
  Files         119      152      +33     
  Lines       10077     9788     -289     
==========================================
+ Hits         5074     5192     +118     
+ Misses       5003     4596     -407     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5a2da...a285819. Read the comment docs.

Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; OCP can be uninstalled for edge cases needing a different default

@JarbasAl JarbasAl merged commit 6aa9211 into OpenVoiceOS:dev Jun 9, 2022
4 of 5 checks passed
@JarbasAl JarbasAl mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants