Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/skill_settings_callback #155

Merged
merged 2 commits into from Jun 10, 2022

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Jun 9, 2022

fixes

Exception in thread Thread-68:
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/home/d_mcknight/PycharmProjects/_.Core/venv/lib/python3.8/site-packages/watchdog/observers/api.py", line 205, in run
    self.dispatch_events(self.event_queue)
  File "/home/d_mcknight/PycharmProjects/_.Core/venv/lib/python3.8/site-packages/watchdog/observers/api.py", line 381, in dispatch_events
    handler.dispatch(event)
  File "/home/d_mcknight/PycharmProjects/_.Core/venv/lib/python3.8/site-packages/watchdog/events.py", line 271, in dispatch
    self.on_any_event(event)
  File "/home/d_mcknight/PycharmProjects/_.Core/venv/lib/python3.8/site-packages/mycroft/util/file_utils.py", line 237, in on_any_event
    self._callback(event.src_path)
TypeError: _handle_settings_file_change() takes 1 positional argument but 2 were given

- add missing argument
- ignore settings file creation, that is dome by the skill and does not need a reload
@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Jun 9, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel June 9, 2022 23:52
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #155 (b9c8e0b) into dev (6ceb058) will increase coverage by 2.70%.
The diff coverage is 42.66%.

@@            Coverage Diff             @@
##              dev     #155      +/-   ##
==========================================
+ Coverage   50.35%   53.05%   +2.70%     
==========================================
  Files         119      152      +33     
  Lines       10077     9791     -286     
==========================================
+ Hits         5074     5195     +121     
+ Misses       5003     4596     -407     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9336a...b9c8e0b. Read the comment docs.

@JarbasAl JarbasAl merged commit 3b145f4 into OpenVoiceOS:dev Jun 10, 2022
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants