Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default cache directory to XDG_CACHE_HOME #159

Merged
merged 3 commits into from Jun 17, 2022

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jun 14, 2022

Updates default behavior to use XDG cache spec
Updated annotations in default config

TODO:

@NeonDaniel NeonDaniel requested a review from JarbasAl June 14, 2022 18:06
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #159 (d7a0029) into dev (6ceb058) will increase coverage by 2.71%.
The diff coverage is 42.36%.

@@            Coverage Diff             @@
##              dev     #159      +/-   ##
==========================================
+ Coverage   50.35%   53.06%   +2.71%     
==========================================
  Files         119      152      +33     
  Lines       10077     9801     -276     
==========================================
+ Hits         5074     5201     +127     
+ Misses       5003     4600     -403     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cf629...d7a0029. Read the comment docs.

@NeonDaniel
Copy link
Member Author

It appears the method referenced here is from ovos_utils and already references /tmp

@NeonDaniel NeonDaniel marked this pull request as ready for review June 14, 2022 18:42
@JarbasAl
Copy link
Member

companion PR OpenVoiceOS/ovos-plugin-manager#66

mycroft/configuration/mycroft.conf Outdated Show resolved Hide resolved
Copy link
Member

@JarbasAl JarbasAl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should pin OPM to include PR above, also left a nitpick for the .conf comment

Change conf comment per feedback
@NeonDaniel NeonDaniel requested a review from JarbasAl June 17, 2022 17:33
@JarbasAl JarbasAl merged commit 88e5a2e into dev Jun 17, 2022
9 of 10 checks passed
@JarbasAl JarbasAl deleted the FIX_CacheDefaultDirectory branch June 17, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants