Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve occasional config init bug #161

Merged
merged 1 commit into from Jun 17, 2022
Merged

Resolve occasional config init bug #161

merged 1 commit into from Jun 17, 2022

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel requested a review from JarbasAl June 15, 2022 20:20
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #161 (f19b3ed) into dev (6ceb058) will increase coverage by 2.70%.
The diff coverage is 42.67%.

@@            Coverage Diff             @@
##              dev     #161      +/-   ##
==========================================
+ Coverage   50.35%   53.05%   +2.70%     
==========================================
  Files         119      152      +33     
  Lines       10077     9791     -286     
==========================================
+ Hits         5074     5195     +121     
+ Misses       5003     4596     -407     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cf629...f19b3ed. Read the comment docs.

@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Jun 15, 2022
@JarbasAl JarbasAl merged commit 9b87ae5 into dev Jun 17, 2022
4 of 5 checks passed
@JarbasAl JarbasAl deleted the FIX_ConfigInitBug branch June 17, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants