feat/yaml_support #162
Merged
feat/yaml_support #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow downstream projects to use yaml as their config format, this can be achieved via ovos.conf
Codecov Report
@@ Coverage Diff @@
## dev #162 +/- ##
==========================================
+ Coverage 50.35% 53.12% +2.77%
==========================================
Files 119 152 +33
Lines 10077 9815 -262
==========================================
+ Hits 5074 5214 +140
+ Misses 5003 4601 -402
Continue to review full report at Codecov.
|
NeonDaniel
requested changes
Jun 17, 2022
added 4 commits
June 17, 2022 17:23
Update `get_file_format` to internal method
NeonJarbas
force-pushed
the
feat/yaml_support
branch
from
a32047a
to
a9bac43
Compare
JarbasAl
approved these changes
Jun 21, 2022
NeonDaniel
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
allow downstream projects to use yaml as their config format, this can be achieved via ovos.conf
The use case for this PR is "mycroft as lib", this is meant for devs creating their own voice assistants on top of ovos-core, your own assistant can now use yaml if you prefer it!
regular users are not affected by this change, the default config format is still commented json.