Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying no retries in MutableMicrophone class #168

Merged
merged 1 commit into from Oct 4, 2022

Conversation

NeonDaniel
Copy link
Member

Currently, the audio_producer will be stuck in an infinite loop if there is no mic attached. This adds a parameter so exceptions can be handled by the calling method (i.e. stop trying if there is no microphone available)

@NeonDaniel NeonDaniel requested a review from JarbasAl July 7, 2022 23:18
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #168 (a97357f) into dev (6ceb058) will increase coverage by 2.62%.
The diff coverage is 41.62%.

@@            Coverage Diff             @@
##              dev     #168      +/-   ##
==========================================
+ Coverage   50.35%   52.97%   +2.62%     
==========================================
  Files         119      152      +33     
  Lines       10077     9482     -595     
==========================================
- Hits         5074     5023      -51     
+ Misses       5003     4459     -544     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33d124...a97357f. Read the comment docs.

@JarbasAl JarbasAl merged commit d4a60a7 into dev Oct 4, 2022
4 of 5 checks passed
@JarbasAl JarbasAl deleted the FIX_MicReloadTimeout branch October 4, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants