Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'None' configuration values for deprecated directory params #172

Merged
merged 1 commit into from Jul 15, 2022

Conversation

NeonDaniel
Copy link
Member

No description provided.

@NeonDaniel NeonDaniel requested a review from JarbasAl July 15, 2022 17:08
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #172 (17c8b0f) into dev (6ceb058) will increase coverage by 2.63%.
The diff coverage is 41.69%.

@@            Coverage Diff             @@
##              dev     #172      +/-   ##
==========================================
+ Coverage   50.35%   52.99%   +2.63%     
==========================================
  Files         119      152      +33     
  Lines       10077     9479     -598     
==========================================
- Hits         5074     5023      -51     
+ Misses       5003     4456     -547     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33d124...17c8b0f. Read the comment docs.

@NeonDaniel NeonDaniel merged commit 34758eb into dev Jul 15, 2022
@NeonDaniel NeonDaniel deleted the FIX_HandleNullSkillsDirectoryConfig branch July 15, 2022 17:27
@JarbasAl JarbasAl added the bug Something isn't working label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants