Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate language intent registration #173

Merged
merged 3 commits into from Jul 18, 2022
Merged

Conversation

NeonDaniel
Copy link
Member

Update _native_langs to ensure a list of unique full language codes is returned

This enforces full language codes and tosses anything without a region (i.e. en is invalid). Should this try to use default regions from LF?

@NeonDaniel NeonDaniel requested a review from JarbasAl July 18, 2022 22:16
@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #173 (87e914e) into dev (6ceb058) will increase coverage by 2.64%.
The diff coverage is 41.71%.

@@            Coverage Diff             @@
##              dev     #173      +/-   ##
==========================================
+ Coverage   50.35%   52.99%   +2.64%     
==========================================
  Files         119      152      +33     
  Lines       10077     9480     -597     
==========================================
- Hits         5074     5024      -50     
+ Misses       5003     4456     -547     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6d317...87e914e. Read the comment docs.

@NeonDaniel NeonDaniel requested a review from JarbasAl July 18, 2022 22:57
@JarbasAl JarbasAl merged commit 92f7be4 into dev Jul 18, 2022
4 of 5 checks passed
@JarbasAl JarbasAl deleted the FIX_NoDuplicateIntents branch July 18, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants