refactor/native_sources #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
historically "audio" and "debug_cli" have been the hardcoded message source/destinations considered native, ie, only those would trigger audio playback for TTS nowadays alternative clients exist and this should be made configurable, Anecdotally, I personally dislike the debug_cli triggering audio, If I am debugging I usually have my own audio playing already and don't want interruptions
Codecov Report
@@ Coverage Diff @@
## dev #179 +/- ##
==========================================
+ Coverage 50.35% 52.97% +2.62%
==========================================
Files 119 152 +33
Lines 10077 9495 -582
==========================================
- Hits 5074 5030 -44
+ Misses 5003 4465 -538
Continue to review full report at Codecov.
|
NeonDaniel
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
historically "audio" and "debug_cli" have been the hardcoded message source/destinations considered native, ie, only those would trigger audio playback for TTS, more info https://github.com/JarbasHiveMind/HiveMind-core/wiki/Mycroft-Messages
nowadays alternative clients exist and this should be made configurable,
Anecdotally, I personally dislike the debug_cli triggering audio, If I am debugging I usually have my own audio playing already and don't want interruptions