Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/gui_cleanup #182

Merged
merged 1 commit into from Aug 6, 2022
Merged

Conversation

NeonJarbas
Copy link

  • fix bus in load_pages due to variable name collision
  • remove debug flag from tornado listener (makes websocket reload and crash during dev when unrelated files change, very annoying)
  • use explicit imports for consistency
  • replace print with log

- fix bus in load_pages due to variable name collision
- remove debug flag from tornado listener
- use explicit imports for consistency
- replace print with log
@JarbasAl JarbasAl added bug Something isn't working refactor code refactor without functional changes bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Aug 6, 2022
@JarbasAl JarbasAl requested a review from AIIX August 6, 2022 20:22
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #182 (0634a27) into dev (6ceb058) will increase coverage by 2.57%.
The diff coverage is 37.58%.

@@            Coverage Diff             @@
##              dev     #182      +/-   ##
==========================================
+ Coverage   50.35%   52.92%   +2.57%     
==========================================
  Files         119      152      +33     
  Lines       10077     9510     -567     
==========================================
- Hits         5074     5033      -41     
+ Misses       5003     4477     -526     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit dff6e9f into OpenVoiceOS:dev Aug 6, 2022
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants