refactor/padacioso #183
Merged
refactor/padacioso #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because fann2 is copyleft it was made optional in ovos-core, padaos was used instead of padatious however padaos is very rigid and made intents virtually unusable, this replaces it with padacioso which is already a dependency dragged by OCP. It should be a little more usable and a drop in replacement this is a temporary measure until OpenVoiceOS#100 is merged in version 0.0.5
JarbasAl
added
enhancement
Codecov Report
@@ Coverage Diff @@
## dev #183 +/- ##
==========================================
+ Coverage 50.35% 53.25% +2.89%
==========================================
Files 119 152 +33
Lines 10077 9532 -545
==========================================
+ Hits 5074 5076 +2
+ Misses 5003 4456 -547
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
allow more than exact matches via the new fuzz flag
NeonDaniel
reviewed
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because fann2 is copyleft padatious was made optional in ovos-core, padaos was optionally used instead of padatious
however padaos has a few problems:
this replaces it with padacioso:
this is a temporary measure until #100 is merged in version 0.0.5
companion PR OpenVoiceOS/padacioso#1
also check padacioso unittests