Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data structure passed to GUI about page #185

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Conversation

NeonDaniel
Copy link
Member

No description provided.

@NeonDaniel NeonDaniel requested a review from AIIX August 12, 2022 17:43
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #185 (0e8ec0a) into dev (6ceb058) will increase coverage by 3.22%.
The diff coverage is 36.67%.

@@            Coverage Diff             @@
##              dev     #185      +/-   ##
==========================================
+ Coverage   50.35%   53.57%   +3.22%     
==========================================
  Files         119      152      +33     
  Lines       10077     9750     -327     
==========================================
+ Hits         5074     5224     +150     
+ Misses       5003     4526     -477     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AIIX AIIX requested review from JarbasAl and removed request for AIIX August 14, 2022 14:36
@AIIX AIIX marked this pull request as ready for review August 14, 2022 14:36
Copy link
Member Author

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an equivalent bus event to remove about data? I'm thinking about maybe removing backend info if a connection is lost or something like displaying the Dashboard URL when the dashboard is active but removing it if the plugin is stopped

@AIIX AIIX merged commit 499aa8f into dev Sep 3, 2022
@AIIX AIIX deleted the FEAT_ConfigurableAboutGui branch September 3, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants