Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Workshop integration tests #187

Merged
merged 7 commits into from Aug 18, 2022
Merged

add Workshop integration tests #187

merged 7 commits into from Aug 18, 2022

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Aug 17, 2022

Also adds disabled OCP tests

@NeonDaniel NeonDaniel changed the title add OCP integration tests add OCP and Workshop integration tests Aug 17, 2022
@NeonDaniel NeonDaniel closed this Aug 18, 2022
@NeonDaniel NeonDaniel reopened this Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #187 (5ad3470) into dev (6ceb058) will increase coverage by 2.87%.
The diff coverage is 37.58%.

@@            Coverage Diff             @@
##              dev     #187      +/-   ##
==========================================
+ Coverage   50.35%   53.23%   +2.87%     
==========================================
  Files         119      152      +33     
  Lines       10077     9532     -545     
==========================================
  Hits         5074     5074              
+ Misses       5003     4458     -545     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NeonDaniel NeonDaniel changed the title add OCP and Workshop integration tests add Workshop integration tests Aug 18, 2022
@NeonDaniel NeonDaniel marked this pull request as ready for review August 18, 2022 18:04
@JarbasAl
Copy link
Member

lets merge this for now and keep track of failing tests here OpenVoiceOS/ovos-ocp-audio-plugin#18

once that PR is merged the fix should be ported here also

@JarbasAl JarbasAl merged commit 361aacf into dev Aug 18, 2022
10 checks passed
@JarbasAl JarbasAl deleted the TEST_OvosCommonPlayTests branch August 18, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants