Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/common_query_tests #188

Merged
merged 3 commits into from Aug 19, 2022
Merged

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Aug 19, 2022

add initial unittests for common query and continuous dialog

also adds a new event to trigger common_query directly without going trough the intent service

add unittests for common query
@NeonJarbas NeonJarbas marked this pull request as draft August 19, 2022 17:31
@JarbasAl JarbasAl marked this pull request as ready for review August 19, 2022 18:09
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #188 (bc16fda) into dev (6ceb058) will increase coverage by 3.86%.
The diff coverage is 37.58%.

Current head bc16fda differs from pull request most recent head e0d428d. Consider uploading reports for the commit e0d428d to get more accurate results

@@            Coverage Diff             @@
##              dev     #188      +/-   ##
==========================================
+ Coverage   50.35%   54.22%   +3.86%     
==========================================
  Files         119      152      +33     
  Lines       10077     9533     -544     
==========================================
+ Hits         5074     5169      +95     
+ Misses       5003     4364     -639     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left some minor feedback

@JarbasAl JarbasAl merged commit 9c7b125 into OpenVoiceOS:dev Aug 19, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants