refactor/selene_api #189
Merged
refactor/selene_api #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
force-pushed
the
refactor/selene_api
branch
from
3130ca6
to
3dc3ea7
Compare
|
@AIIX this new Settings class in selene_api package should plugin nicely with your old skill settings UI PR MycroftAI#2698 you can manipulate skill settings with just the skill_id and auto generate settingsmeta when missing from selene_api.settings import RemoteSkillSettings
# in ovos-core skill_id is deterministic and safe
# this will also load existing settings file from XDG path
s = RemoteSkillSettings("skill.author")
# in mycroft-core please ensure a valid remote_id
# in MycroftSkill class you can use
# remote_id = self.settings_meta.skill_gid
# s = RemoteSkillSettings("skill.author", remote_id="@|whatever_msm_decided")
s.download()
s.settings["existing_value"] = True
s.settings["new_value"] = "will NOT show up in UI"
s.upload()
# auto generate new settings meta for all new values before uploading
s.settings["new_value"] = "will show up in UI"
s.generate_meta() # now "new_value" is in meta
s.upload() |
JarbasAl
force-pushed
the
refactor/selene_api
branch
from
c0b3839
to
6e49c00
Compare
move api tests to integration_tests for selene_api support runtime backend url changes fix api unittests notes on skill manifest and marketplace comment about manifest upload configurable 2waysync restore precise upload includes MycroftAI#2753 upload meta settings handling refactor/selene_api ovos-stt-plugin-selene requirements.txt requires_backend decorator
JarbasAl
force-pushed
the
refactor/selene_api
branch
from
6e49c00
to
67b35ba
Compare
Codecov Report
@@ Coverage Diff @@
## dev #189 +/- ##
==========================================
+ Coverage 50.35% 54.24% +3.89%
==========================================
Files 119 156 +37
Lines 10077 9761 -316
==========================================
+ Hits 5074 5295 +221
+ Misses 5003 4466 -537
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
refactor to use https://github.com/OpenVoiceOS/selene_api