Port supported languages API from Neon speech/audio modules #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #190 +/- ##
==========================================
+ Coverage 50.35% 54.18% +3.83%
==========================================
Files 119 152 +33
Lines 10077 9543 -534
==========================================
+ Hits 5074 5171 +97
+ Misses 5003 4372 -631
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JarbasAl
reviewed
Aug 26, 2022
JarbasAl
reviewed
Aug 26, 2022
JarbasAl
reviewed
Aug 26, 2022
JarbasAl
reviewed
Aug 26, 2022
NeonDaniel
pushed a commit
to NeonGeckoCom/neon_speech
that referenced
this pull request
Aug 26, 2022
NeonDaniel
pushed a commit
to NeonDaniel/neon_audio
that referenced
this pull request
Aug 26, 2022
NeonDaniel
added a commit
to NeonGeckoCom/neon_speech
that referenced
this pull request
Aug 26, 2022
* Add bus API method to get supported languages with unit test * Fix unit test to account for default return value * Fix mocking in API tests * Troubleshooting default value Add docstring to added method * Refactor changes on OpenVoiceOS/ovos-core#190 * Update missed message change in unit tests * Update missed message param change in unit tests * Cleanup changes Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
added a commit
to NeonGeckoCom/neon_audio
that referenced
this pull request
Aug 26, 2022
* Add neon.get_languages_tts event handler with unit test Update Docker ovos config * Rebase changes on OpenVoiceOS/ovos-core#190 * Fix ovos-core dependency spec * Troubleshooting dependency resolution bug in GH actions Co-authored-by: Daniel McKnight <daniel@neon.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.