Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Neon leftovers from ported language API #191

Merged
merged 3 commits into from Aug 26, 2022
Merged

Conversation

NeonDaniel
Copy link
Member

Fixes bugs missed in #190

@NeonDaniel NeonDaniel marked this pull request as draft August 26, 2022 19:32
@NeonDaniel NeonDaniel marked this pull request as ready for review August 26, 2022 19:35
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #191 (3e41f23) into dev (6ceb058) will increase coverage by 3.83%.
The diff coverage is 37.52%.

@@            Coverage Diff             @@
##              dev     #191      +/-   ##
==========================================
+ Coverage   50.35%   54.18%   +3.83%     
==========================================
  Files         119      152      +33     
  Lines       10077     9543     -534     
==========================================
+ Hits         5074     5171      +97     
+ Misses       5003     4372     -631     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit acc5c3f into dev Aug 26, 2022
4 checks passed
@JarbasAl JarbasAl deleted the PATCH_LangugeAPIPort branch August 26, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants