Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement namespace global back button management for mobile #194

Merged
merged 1 commit into from Sep 16, 2022

Conversation

AIIX
Copy link
Member

@AIIX AIIX commented Sep 14, 2022

  • Implements global back button management in gui namespace for mobile

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #194 (66d9ea8) into dev (6ceb058) will increase coverage by 3.13%.
The diff coverage is 36.63%.

@@            Coverage Diff             @@
##              dev     #194      +/-   ##
==========================================
+ Coverage   50.35%   53.48%   +3.13%     
==========================================
  Files         119      153      +34     
  Lines       10077     9793     -284     
==========================================
+ Hits         5074     5238     +164     
+ Misses       5003     4555     -448     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 139 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit f8e5c7f into dev Sep 16, 2022
4 checks passed
@JarbasAl JarbasAl deleted the fix/mobile/global-back-navigation-1 branch September 16, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants