Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/listen_sound #195

Merged
merged 2 commits into from Sep 21, 2022
Merged

fix/listen_sound #195

merged 2 commits into from Sep 21, 2022

Conversation

JarbasAl
Copy link
Member

on external listen triggers the sound config was not respected, eg, in get_response

on external listen triggers the sound config was not respected, eg, in get_response
@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #195 (920564d) into dev (6ceb058) will increase coverage by 3.12%.
The diff coverage is 36.67%.

@@            Coverage Diff             @@
##              dev     #195      +/-   ##
==========================================
+ Coverage   50.35%   53.48%   +3.12%     
==========================================
  Files         119      153      +34     
  Lines       10077     9796     -281     
==========================================
+ Hits         5074     5239     +165     
+ Misses       5003     4557     -446     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 139 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mycroft/listener/mic.py Outdated Show resolved Hide resolved
mycroft/listener/mic.py Show resolved Hide resolved
@JarbasAl JarbasAl merged commit 1d42507 into dev Sep 21, 2022
4 checks passed
@JarbasAl JarbasAl deleted the fix/listen_sound branch September 21, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants