Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/selene_api -> ovos-backend-client #201

Merged
merged 11 commits into from Oct 4, 2022
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 2, 2022

companion PR to OpenVoiceOS/ovos-backend-client#10

Backend Overview

API Offline Personal Selene
Admin yes [1] yes no
Device yes [2] yes yes
Metrics yes [2] yes yes
Dataset yes [2] yes yes
OAuth yes [2] yes yes
Wolfram yes [3] yes yes
Geolocate yes yes yes
STT yes [3] yes yes
Weather yes [3] yes yes
Email yes [3] yes yes
[1] will update user level mycroft.conf
[2] shared json database with personal backend for UI compat
[3] needs additional configuration (eg. credentials)

more WIP backends -> OpenVoiceOS/ovos-backend-client#11

@JarbasAl JarbasAl added the enhancement New feature or request label Oct 2, 2022
@JarbasAl JarbasAl marked this pull request as ready for review October 4, 2022 13:06
@JarbasAl
Copy link
Member Author

JarbasAl commented Oct 4, 2022

needs OpenVoiceOS/ovos-config#18 to be merged and version pinned together

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #201 (5bbfb61) into dev (6ceb058) will increase coverage by 3.84%.
The diff coverage is 36.93%.

@@            Coverage Diff             @@
##              dev     #201      +/-   ##
==========================================
+ Coverage   50.35%   54.19%   +3.84%     
==========================================
  Files         119      156      +37     
  Lines       10077     9718     -359     
==========================================
+ Hits         5074     5267     +193     
+ Misses       5003     4451     -552     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 140 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl
Copy link
Member Author

JarbasAl commented Oct 4, 2022

OpenVoiceOS/skill-ovos-setup#23 should be merged together with this one

mycroft/__init__.py Show resolved Hide resolved
mycroft/configuration/mycroft.conf Show resolved Hide resolved
mycroft/skills/mycroft_skill/mycroft_skill.py Show resolved Hide resolved
test/integrationtests/test_selene_api.py Show resolved Hide resolved
@JarbasAl JarbasAl merged commit ee9a14c into dev Oct 4, 2022
9 checks passed
@JarbasAl JarbasAl deleted the feat/bump_selene_api branch October 4, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants