Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI buttons vertical screen issues in developer settings #203

Merged
merged 1 commit into from Oct 4, 2022

Conversation

AIIX
Copy link
Member

@AIIX AIIX commented Oct 3, 2022

Fixes for vertical display button issue

  • Moves advanced configuration button location to lower bottom of the screen
  • Adds buffer text to advanced configuration page

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #203 (db237af) into dev (6ceb058) will increase coverage by 3.84%.
The diff coverage is 36.89%.

@@            Coverage Diff             @@
##              dev     #203      +/-   ##
==========================================
+ Coverage   50.35%   54.20%   +3.84%     
==========================================
  Files         119      156      +37     
  Lines       10077     9771     -306     
==========================================
+ Hits         5074     5296     +222     
+ Misses       5003     4475     -528     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Oct 4, 2022
@JarbasAl JarbasAl merged commit 9149e61 into dev Oct 4, 2022
4 checks passed
@JarbasAl JarbasAl deleted the fix/settings-ui-button-issues branch October 4, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants