Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/pairing_check_again #205

Merged
merged 2 commits into from Oct 7, 2022
Merged

fix/pairing_check_again #205

merged 2 commits into from Oct 7, 2022

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 5, 2022

No description provided.

@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #205 (5c950e1) into dev (6ceb058) will increase coverage by 3.79%.
The diff coverage is 36.94%.

@@            Coverage Diff             @@
##              dev     #205      +/-   ##
==========================================
+ Coverage   50.35%   54.14%   +3.79%     
==========================================
  Files         119      156      +37     
  Lines       10077     9738     -339     
==========================================
+ Hits         5074     5273     +199     
+ Misses       5003     4465     -538     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NeonDaniel
Copy link
Member

Still troubleshooting, but this did not resolve the issue for me and homescreen overrode setup during STT selection

@JarbasAl
Copy link
Member Author

JarbasAl commented Oct 7, 2022

the bug is likely in setup skill, something is changing state to "finished" too soon, we should add logs there for further info, but this PR should still be valid, now there is a distinction between finished and inactive that should help debug this better

@JarbasAl JarbasAl merged commit ab474ea into dev Oct 7, 2022
4 checks passed
@JarbasAl JarbasAl deleted the fix/pairing_check_again branch October 7, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants