fix/ww_cfg #207
Merged
fix/ww_cfg #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle naming collisions due to white space and underscore differences handle "active" flag based on the concept of "main wake word", compatible with the mycroft way and expectations, multiple wake words will require explicitly setting "active": True in config from now on fix possible iteration bug on stop
JarbasAl
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #207 +/- ##
==========================================
+ Coverage 50.35% 54.17% +3.82%
==========================================
Files 119 156 +37
Lines 10077 9733 -344
==========================================
+ Hits 5074 5273 +199
+ Misses 5003 4460 -543
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NeonDaniel
approved these changes
Oct 7, 2022
JarbasAl
commented
Oct 7, 2022
| # normalization step to avoid naming collisions | ||
| # TODO - move this to ovos_config package, on changes to the hotwords section this should be enforced directly | ||
| # this approach does not fully solve the issue, config merging may be messed up | ||
| word = word.replace(" ", "_") |
There was a problem hiding this comment.
@NeonDaniel a bit out of scope but related, should we enforce this in every key for mycroft.conf, not only for hotwords?
There was a problem hiding this comment.
I agree its out of scope.. My main concern would be breaking compatibility with plugin config; maybe we could log warnings about it in ovos_config and then remove it when we release 1.0.0 there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
handle naming collisions due to white space and underscore differences
handle "active" flag based on the concept of "main wake word", compatible with the mycroft way and expectations, multiple wake words will require explicitly setting "active": True in config from now on
fix possible iteration bug on stop