Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/xdg_logs #210

Merged
merged 2 commits into from Oct 10, 2022
Merged

feat/xdg_logs #210

merged 2 commits into from Oct 10, 2022

Conversation

JarbasAl
Copy link
Member

bump ovos_utils and make python log to file under XDG_STATE_HOME

companion PR to OpenVoiceOS/ovos-utils#69

@JarbasAl JarbasAl added the enhancement New feature or request label Oct 10, 2022
bump ovos_utils and make python log to file under XDG_STATE_HOME
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #210 (46e5a38) into dev (6ceb058) will increase coverage by 3.64%.
The diff coverage is 36.51%.

❗ Current head 46e5a38 differs from pull request most recent head c1963fd. Consider uploading reports for the commit c1963fd to get more accurate results

@@            Coverage Diff             @@
##              dev     #210      +/-   ##
==========================================
+ Coverage   50.35%   53.99%   +3.64%     
==========================================
  Files         119      156      +37     
  Lines       10077     9751     -326     
==========================================
+ Hits         5074     5265     +191     
+ Misses       5003     4486     -517     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 145 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -99,7 +99,7 @@ function launch-background() {
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this script being added to this repo, but it should be removed, launchers do not belong here specially if platform specific... in general launch.sh scripts are not recommended, setup.py provides proper entrypoints when installed, please use those

@AIIX not sure if you are using it, will let you deprecate this cleanly instead of removing it now

@JarbasAl JarbasAl merged commit b64dc28 into dev Oct 10, 2022
@JarbasAl JarbasAl deleted the feat/xdg_logs branch October 10, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant