Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/error_sound #211

Merged
merged 3 commits into from Oct 10, 2022
Merged

feat/error_sound #211

merged 3 commits into from Oct 10, 2022

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 10, 2022

Add a new error sound effect

Add support for end_listening sound, documented in mycroft.conf but not implemented

as reported in chat the default dialog claiming core is still booting up is very misleading, this has been removed from listener service, it really was a hack so it was now replaced with a error sound

@JarbasAl JarbasAl added the enhancement New feature or request label Oct 10, 2022
Add a new error sound effect
documented in mycroft.conf but unimplemented
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #211 (f9866e7) into dev (6ceb058) will increase coverage by 3.65%.
The diff coverage is 36.73%.

@@            Coverage Diff             @@
##              dev     #211      +/-   ##
==========================================
+ Coverage   50.35%   54.01%   +3.65%     
==========================================
  Files         119      156      +37     
  Lines       10077     9761     -316     
==========================================
+ Hits         5074     5272     +198     
+ Misses       5003     4489     -514     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 142 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit c2fc006 into dev Oct 10, 2022
4 checks passed
@JarbasAl JarbasAl deleted the feat/error_sound branch October 10, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant