Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/backwards_compat #213

Merged
merged 1 commit into from Oct 13, 2022
Merged

fix/backwards_compat #213

merged 1 commit into from Oct 13, 2022

Conversation

JarbasAl
Copy link
Member

some places expect the config locations variables to be available under mycroft.configuration.config module

seen in ovos-alarm-skill

some places expect the config locations variables to be available under mycroft.configuration.config module
@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels Oct 13, 2022
@JarbasAl JarbasAl requested a review from j1nx October 13, 2022 18:45
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #213 (4662578) into dev (6ceb058) will increase coverage by 3.57%.
The diff coverage is 36.62%.

@@            Coverage Diff             @@
##              dev     #213      +/-   ##
==========================================
+ Coverage   50.35%   53.93%   +3.57%     
==========================================
  Files         119      156      +37     
  Lines       10077     9779     -298     
==========================================
+ Hits         5074     5274     +200     
+ Misses       5003     4505     -498     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit ca7899b into dev Oct 13, 2022
4 checks passed
@JarbasAl JarbasAl deleted the fix/backwards_compat branch October 13, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant