Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/opm query api #220

Merged
merged 7 commits into from Nov 11, 2022
Merged

feat/opm query api #220

merged 7 commits into from Nov 11, 2022

Conversation

JarbasAl
Copy link
Member

add a bus interface to query available plugins per service

@JarbasAl JarbasAl added the enhancement New feature or request label Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #220 (a7b12fb) into dev (6ceb058) will increase coverage by 4.47%.
The diff coverage is 43.31%.

@@            Coverage Diff             @@
##              dev     #220      +/-   ##
==========================================
+ Coverage   50.35%   54.82%   +4.47%     
==========================================
  Files         119      156      +37     
  Lines       10077     9310     -767     
==========================================
+ Hits         5074     5104      +30     
+ Misses       5003     4206     -797     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review October 19, 2022 04:54
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments suggesting docstrings and possible test improvements

mycroft/audio/service.py Show resolved Hide resolved
mycroft/audio/service.py Show resolved Hide resolved
test/unittests/audio/test_speech.py Show resolved Hide resolved
add a bus interface to query available plugins per service
@JarbasAl JarbasAl merged commit 8eb73e6 into dev Nov 11, 2022
5 checks passed
@JarbasAl JarbasAl deleted the feat/opm_query_api branch November 11, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants