refactor SkillGUI class to import from ovos_utils

[JarbasAl]

there was a bunch of duplicated code and the API was starting to get out of sync with ovos_utils getting new features such as notifications support

[codecov]

Codecov Report

Merging #224 (778afa2) into dev (6ceb058) will increase coverage by 2.12%.
The diff coverage is 36.75%.

@@            Coverage Diff             @@
##              dev     #224      +/-   ##
==========================================
+ Coverage   50.35%   52.47%   +2.12%     
==========================================
  Files         119      156      +37     
  Lines       10077     9154     -923     
==========================================
- Hits         5074     4804     -270     
+ Misses       5003     4350     -653     

Impacted Files	Coverage Δ
mycroft/audio/__main__.py	0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py	0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py	0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py	0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py	0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py	0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py	0.00% <0.00%> (-88.89%)	⬇️
mycroft/client/speech/service.py	0.00% <0.00%> (ø)
mycroft/client/speech/silence.py	0.00% <0.00%> (-42.86%)	⬇️
mycroft/client/text/__init__.py	0.00% <0.00%> (ø)
... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[AIIX]

This will make GUI completely ovos-utils dependent and also means gui skills will also now indirectly become ovos utils dependent, i don't see how that is a good thing, and why it all needs to be moved outside core, if anything ovos-utils gui changes should be moved here instead for better sync than live outside core

[AIIX]

request to avoid merging this till its better tested, seems it removes a lot of GUI specific code

[JarbasAl]

This will make GUI completely ovos-utils dependent and also means gui skills will also now indirectly become ovos utils dependent, i don't see how that is a good thing, and why it all needs to be moved outside core, if anything ovos-utils gui changes should be moved here instead for better sync than live outside core

you added the new notification utils there because they are used in PHAL plugins etc, in ovos things other than skills can have a GUI interface.

there was no code removed here, all code you see deleted is the exact same function in ovos_utils,

ovos_utils is already a dependency of ovos-core. MycroftSkill class will remain working exactly the same, skills will not be tied to ovos_utils at all since they import from mycroft module. this doesnt even add a new dependency

also we cant really extend this class with new public methods just like skills, because then if a skill uses the new methods it wont run in mycroft-core. moving the changes from ovos-utils here is exactly the wrong thing to do since it breaks backwards compat and blocks plugins from having a GUI

[AIIX]

This will make GUI completely ovos-utils dependent and also means gui skills will also now indirectly become ovos utils dependent, i don't see how that is a good thing, and why it all needs to be moved outside core, if anything ovos-utils gui changes should be moved here instead for better sync than live outside core

you added the new notification utils there because they are used in PHAL plugins etc, in ovos things other than skills can have a GUI interface.

there was no code removed here, all code you see deleted is the exact same function in ovos_utils,

ovos_utils is already a dependency of ovos-core. MycroftSkill class will remain working exactly the same, skills will not be tied to ovos_utils at all since they import from mycroft module. this doesnt even add a new dependency

also we cant really extend this class with new public methods just like skills, because then if a skill uses the new methods it wont run in mycroft-core. moving the changes from ovos-utils here is exactly the wrong thing to do since it breaks backwards compat and blocks plugins from having a GUI

This is still untested, and I would like to test this PR running on device with everything before I can say nothing breaks in GUI with this change

[builderjer]

I've been testing, and have no seen issues