Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/reload mid tts/stt #225

Merged
merged 1 commit into from Oct 25, 2022
Merged

fix/reload mid tts/stt #225

merged 1 commit into from Oct 25, 2022

Conversation

JarbasAl
Copy link
Member

if config changed TTS and STT could reload mid execution and cut speech, this commit adds Locks to avoid both happening at same time

if config changed TTS and STT could reload mid execution and cut speech, this commit adds Locks to avoid both happening at same time
@JarbasAl JarbasAl added the bug Something isn't working label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #225 (279a411) into dev (6ceb058) will increase coverage by 2.48%.
The diff coverage is 36.63%.

@@            Coverage Diff             @@
##              dev     #225      +/-   ##
==========================================
+ Coverage   50.35%   52.84%   +2.48%     
==========================================
  Files         119      156      +37     
  Lines       10077     9275     -802     
==========================================
- Hits         5074     4901     -173     
+ Misses       5003     4374     -629     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AIIX
AIIX approved these changes Oct 25, 2022
@JarbasAl JarbasAl merged commit 51af049 into dev Oct 25, 2022
5 checks passed
@JarbasAl JarbasAl deleted the fix/reload_mid_tts_stt branch October 25, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants