Replace / by _ in name to avoid issue when writing the cache file. #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unit test result expectation. Use md5 from hashlib instead of hash(). Use basename and hash of the full path to register entities. Replace / by _ in name to avoid issue when writing the cache file.
JarbasAl
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #228 +/- ##
==========================================
+ Coverage 50.35% 52.46% +2.11%
==========================================
Files 119 156 +37
Lines 10077 9160 -917
==========================================
- Hits 5074 4806 -268
+ Misses 5003 4354 -649
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NeonDaniel
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
port MycroftAI#3133