feat/extract_yes_no #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new parse method, in core and skills we have this snippet of code over and over
```
if self.voc_match("yes"):
...
elif self.voc_match("no"):
...
else:
...
```
this formalizes it under LF to keep lang support centralized, the .voc files are replace with a single .json file, supporting a new language only requires the addition of this file
initial yesno.json files have been automatically sourced by parsing mycroft/res/text
Codecov Report
@@ Coverage Diff @@
## dev #30 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 65
Lines ? 16401
Branches ? 0
=====================================
Hits ? 0
Misses ? 16401
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ted exception instead
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 4, 2022
companion PR to OpenVoiceOS/ovos-lingua-franca#30
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 4, 2022
* feat/lf_ask_yeno companion PR to OpenVoiceOS/ovos-lingua-franca#30 * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
in core and skills we have this snippet of code over and over
problem statement: given the answer to a yes/no question, did the user mean yes / no / neutral ?
this PR adds a new generic parse method
this formalizes it under LF to keep lang support centralized, the .voc files are replaced with a single .json file, supporting a new language only requires the addition of this file
initial yesno.json files have been automatically sourced by parsing mycroft/res/text
related mycroft issues/PRs: