NeonDaniel refactor/ovos workshop settings + deprecate OCPSettings (#36)
6277b24 Jan 19, 2023
refactor/ovos workshop settings + deprecate OCPSettings (#36)
* Deprecate `OCPSettings` object and refactor references
Includes cleanup of some docstrings and editor warnings

* Address PR review

* Fix settings updates from passed values
Update test patching to troubleshoot failures

* Handle default settings from config file

* Move import from module to class to troubleshoot circular import error

* Remove type annotations causing circular import errors
Reorg imports

* Refactor OCPMediaPlayer init to handle settings changes

* Update missed OCPSettings property references

* Ensure safe default 'mode' config

* Reorg player init to resolve test failures

* Reorg unit tests to test Mycroft separate from OVOS to avoid LF dependency bug

* Remove redundant ovos-core install in automation

* Remove `settings` kwarg since settings is defined after super() call

* Add global "OCP_ID" and update references

* Shuffle definitions to resolve circular imports

* Shuffle definitions to resolve circular imports

* Shuffle definitions to resolve circular imports
Refactor `ovos.common_play` to OCP_ID (`ovos_common_play`)

* refactor id to ovos.common_play for backwards-compat bus messages
6277b24