Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/3rdparty #33

Merged
merged 1 commit into from Sep 21, 2022
Merged

Refactor/3rdparty #33

merged 1 commit into from Sep 21, 2022

Conversation

JarbasAl
Copy link
Member

companion PR to the new UI repo

  • makes the weather/wolfram providers more easily configurable (already in UI repo)
  • easier to extend providers
  • add method to delete device from database (already in UI repo)
  • fix a bug with device deserialization do to kwarg naming mismatch

@JarbasAl JarbasAl added bug Something isn't working refactor code improvements with no functional changes labels Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

No coverage uploaded for pull request base (dev@65882e6). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #33   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      21           
  Lines          ?    1381           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    1381           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit ab30977 into dev Sep 21, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant