feat/geolocation_providers #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes the service provider for geolocation api configurable instead of hardcoding OpenStreetMap options: - OpenStreetMap - Geocode Farm - ArcGIS - Selene (if proxy enabled) most of the providers in geocoders lib are buggy due to api updates, we should migrate to geopy instead which is actually maintained, the above are the only functional free providers in geocoder lib
Codecov Report
@@ Coverage Diff @@
## dev #34 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 21
Lines ? 1428
Branches ? 0
=====================================
Hits ? 0
Misses ? 1428
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-backend-manager
that referenced
this pull request
Sep 23, 2022
JarbasAl
added a commit
to OpenVoiceOS/ovos-backend-manager
that referenced
this pull request
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
makes the service provider for geolocation api configurable instead of hardcoding OpenStreetMap
options:
most of the providers in geocoders lib are buggy due to api updates, we should migrate to geopy instead which is actually maintained, the above are the only functional free providers in geocoder lib