From dea459e8fbcedfef26022ddc4567be078a6e0b6d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 06:51:48 -0500 Subject: [PATCH 1/3] Bump actions/setup-node from 2.3.1 to 2.4.0 (#52) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/v2.3.1...v2.4.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/nodejs-beta.yml | 4 ++-- .github/workflows/nodejs.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nodejs-beta.yml b/.github/workflows/nodejs-beta.yml index 1549a07e..3fee5a6b 100644 --- a/.github/workflows/nodejs-beta.yml +++ b/.github/workflows/nodejs-beta.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2.3.4 - - uses: actions/setup-node@v2.3.1 + - uses: actions/setup-node@v2.4.0 with: node-version: 14 - name: npm install @@ -31,7 +31,7 @@ jobs: steps: - uses: actions/checkout@v2.3.4 - - uses: actions/setup-node@v2.3.1 + - uses: actions/setup-node@v2.4.0 with: node-version: 14 registry-url: https://registry.npmjs.org/ diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 8bd28458..07efae7d 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -19,7 +19,7 @@ jobs: steps: - uses: actions/checkout@v2.3.4 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2.3.1 + uses: actions/setup-node@v2.4.0 with: node-version: ${{ matrix.node-version }} - name: npm install @@ -38,7 +38,7 @@ jobs: steps: - uses: actions/checkout@v2.3.4 - - uses: actions/setup-node@v2.3.1 + - uses: actions/setup-node@v2.4.0 with: node-version: 14 # use the minimum required version registry-url: https://registry.npmjs.org/ From f2bece929382c41670ce6ecf343d1884d203c3f8 Mon Sep 17 00:00:00 2001 From: Mingky Kim <45954551+mingkyme@users.noreply.github.com> Date: Sun, 29 Aug 2021 18:17:45 +0900 Subject: [PATCH 2/3] missing declare ad_id When put params with id, it cause error. FATAL ERROR: ad_id is not defined --- lib/switchbot.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/switchbot.js b/lib/switchbot.js index 6ad0eeed..3f7e2717 100644 --- a/lib/switchbot.js +++ b/lib/switchbot.js @@ -221,7 +221,7 @@ class Switchbot { } if (id) { id = id.toLowerCase().replace(/\:/g, ''); - ad_id = ad.address.toLowerCase().replace(/[^a-z0-9]/g, ''); + let ad_id = ad.address.toLowerCase().replace(/[^a-z0-9]/g, ''); if (ad_id !== id) { return false; } @@ -363,4 +363,4 @@ class Switchbot { } -module.exports = Switchbot; \ No newline at end of file +module.exports = Switchbot; From 59c29ba77fcd88c2821e6c8ceb27feb115ac527a Mon Sep 17 00:00:00 2001 From: Mingky Kim <45954551+mingkyme@users.noreply.github.com> Date: Sun, 29 Aug 2021 18:20:11 +0900 Subject: [PATCH 3/3] remove new line --- lib/switchbot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/switchbot.js b/lib/switchbot.js index 3f7e2717..cfa5ed66 100644 --- a/lib/switchbot.js +++ b/lib/switchbot.js @@ -363,4 +363,4 @@ class Switchbot { } -module.exports = Switchbot; +module.exports = Switchbot; \ No newline at end of file