fix bug where mercy or nike cross is erroneously awarded for instance… #1179
Conversation
…s where someone gets all the kills and someone else gets all the stuns in a single mission (supposed to be all aliens killed or stunned by single person)
|
What happens if a soldier kills+stuns every alien on a mission? |
|
Let me do another test run, but should be no award. In theory, might need to be a new award, since nike implies kill all aliens and mercy implies stun all aliens based on their descriptions. You can't both kill all and stun all at the same time, just kill some and stun some but knock down all. |
|
Ran test. No medal as expected. I can handle this two ways: implement a new award for taking out all the aliens with whatever means necessary, or I may have to edit the commendations. I was trying to avoid changing the mod too much, since I didn't write it or the code to go with it. I'm just trying to fix obvious errors based on their descriptions per Meridian's request. Should I see if can get in contact with Shoes? EDIT: Third option suggested to me by IvanDogovich: Let nike cross be "eliminate all" award that includes both stun and kill (since nike is easier) and let mercy still be stun all since stunning all is harder to obtain. This solution would require less changes over all. 2 lines of code in DebriefingState.cpp to implement over current PR, one comment in BattleUnitStatistics.h and two lines in Commendations. |
|
I like Ivan's proposal. Nike cross for "eliminate (=stun or kill) all" and Mercy cross for "stun all". |
|
I approve. Let's go with door number 3. While you're there, please change "if (aliensKilled)" to "if (aliensKilled == 0)", as mixing ints and bools is kinda confusing. |
|
Okay. I'll do that. Both door number 3 and fix aliensKilled (aliensStunned). |
|
Done, and done |
The Nike cross and the mercy cross are only supposed to be awarded to the soldier who single-handedly either kills all the aliens or stuns all the aliens on a mission respectively. This fixes the problem by at least insuring that the aliens were either all killed or all stunned. Before this fix, a soldier could get the mercy cross by stunning all the stunned aliens, but not all aliens in the mission were stunned. Same for kills.